Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-41829: Adjustments made to thread api #11831

Merged
merged 0 commits into from
Feb 24, 2023

Conversation

mattwrightva
Copy link
Contributor

@mattwrightva mattwrightva commented Feb 17, 2023

Summary

The parameters that the MHV API accepts for the thread list call have been moved from the path to query parameters. Some model changes were made as well to match response changes from the MHV API.

Related issue(s)

https://vajira.max.gov/browse/MHV-41829

Testing done

The thread list tests were adjusted for this change.

Screenshots

No UI changes

What areas of the site does it impact?

This impacts the VA.gov MHV SM API folders and threads endpoints.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mattwrightva mattwrightva requested review from a team as code owners February 17, 2023 01:34
@va-vfs-bot va-vfs-bot temporarily deployed to MHV-41829-thread-api-adjustments/main/main February 17, 2023 01:44 Inactive
robertbylight
robertbylight previously approved these changes Feb 17, 2023
Copy link
Contributor

@robertbylight robertbylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@mmoyer-va mmoyer-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameters changed -- now they are "pageNum" and "pageSize."

@va-vfs-bot va-vfs-bot temporarily deployed to MHV-41829-thread-api-adjustments/main/main February 24, 2023 17:21 Inactive
@mattwrightva mattwrightva merged commit f1a39f0 into master Feb 24, 2023
@mattwrightva mattwrightva deleted the MHV-41829-thread-api-adjustments branch February 24, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants