-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[53040] Mocked Authentication authorize
route setup
#11867
Conversation
a4a9ab4
to
f0423ae
Compare
f0423ae
to
17f5ce2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested and found MockCredentialInfo
in redis. Just a comment about adding mount specs that doesn't necessarily need to be done in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have a request for a couple small changes. For functionality, tested hitting the route and confirmed that a redis record was created as expected with a matching code to reference it downstream
...cked_authentication/app/controllers/mocked_authentication/credential_providers_controller.rb
Show resolved
Hide resolved
modules/mocked_authentication/app/models/mocked_authentication/mock_credential_info.rb
Show resolved
Hide resolved
...cked_authentication/app/controllers/mocked_authentication/credential_providers_controller.rb
Outdated
Show resolved
Hide resolved
...cked_authentication/app/controllers/mocked_authentication/credential_providers_controller.rb
Show resolved
Hide resolved
24e1028
4eb34b4
to
24e1028
Compare
6840957
to
903bf0b
Compare
Generated by 🚫 Danger |
authorize
route setup
authorize
route setupauthorize
route setup
...les/mocked_authentication/app/services/mocked_authentication/mock_credential_info_creator.rb
Outdated
Show resolved
Hide resolved
d7097c7
to
14e8cc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. Looks good!
d69de11
to
3c2029d
Compare
3c2029d
to
ba0e06e
Compare
12e6c25
to
6bb25c4
Compare
Summary
authorize
route to the new Mocked Authentication module. The route currently takes (and validates) a CSPtype
param as a URI-encoded JSON string through thecredential_info
URL param. If the request passes this validation the JSON hash will be stored with a generated code as its key, this code is then returned as the response:credential_info_code
, which you can then use in a Rails console to look up the corresponding Redis data:Related issue(s)
Testing done
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?