Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 24421 remove participant claimant #11871

Merged
merged 0 commits into from
Feb 27, 2023

Conversation

mchristiansonVA
Copy link
Contributor

Summary

  • Optional claimaintParticipantId has been removed as a parameter for the ITF submit endpoint.
  • Note this is branched off of API-24399_Update_HTTP_error_response, and should be merged after API-24399 changes have been merged.

Related issue(s)

API-24421

Testing done

  • ITF submit endpoint formerly accepted a claimantParticipantId parameter; manually tested with Postman to ensure the endpoint still handles submissions for all ITF types without parameter and ignores if supplied.
  • Confirmed validation for claimantParticipantId parameter was removed.
  • Tested ITF "survivor" submission parameter handling for claimantSsn and claimantParticipantId; confirmed backend requests to BGS were correctly adding claimant_participant_id to the request.
  • Confirmed HTTP 422 returned for ITF type "survivor" w/ no claimantSsn param supplied, or when claimantSsn param is the same value as veteran SSN.

What areas of the site does it impact?

  • Claims API ITF submit endpoint.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels Feb 22, 2023
@mchristiansonVA mchristiansonVA self-assigned this Feb 22, 2023
@mchristiansonVA mchristiansonVA requested review from a team as code owners February 22, 2023 19:45
@va-vfs-bot va-vfs-bot temporarily deployed to API-24421_Remove_participantClaimantId/main/main February 22, 2023 19:52 Inactive
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mchristiansonVA mchristiansonVA merged commit 7bb5376 into master Feb 27, 2023
@mchristiansonVA mchristiansonVA deleted the API-24421_Remove_participantClaimantId branch February 27, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants