Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4700: handle nil filters #11874

Merged
merged 0 commits into from
Feb 23, 2023
Merged

4700: handle nil filters #11874

merged 0 commits into from
Feb 23, 2023

Conversation

kpethtel
Copy link
Contributor

@kpethtel kpethtel commented Feb 22, 2023 •
edited
Loading

Summary

  • fixes a small issue found with list filter in the testing process

Related issue(s)

Testing done

This arose from integration testing that was done on a separate branch and tested on a review instance.

Screenshots

What areas of the site does it impact?

None at this time. Code is unused.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@kpethtel kpethtel requested review from a team as code owners February 22, 2023 22:26
@va-vfs-bot va-vfs-bot temporarily deployed to 4700-nil-filters/main/main February 22, 2023 22:33 Inactive
@kpethtel kpethtel mentioned this pull request Feb 22, 2023
Closed
aherzberg
aherzberg approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpethtel kpethtel merged commit e962553 into master Feb 23, 2023
@kpethtel kpethtel deleted the 4700-nil-filters branch February 23, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherzberg aherzberg aherzberg approved these changes

Assignees
No one assigned
Labels
mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpethtel @aherzberg @va-vfs-bot