Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53789 feature toggle for organic login adoption #11879

Merged
merged 0 commits into from
Feb 27, 2023

Conversation

holytoastr
Copy link
Contributor

@holytoastr holytoastr commented Feb 23, 2023

Summary

  • Added feature flag for organic login.gov adoption experiment
  • Added devs to flipper admin list for testing
  • Team: Identity

Related issue(s)

Testing done

  • Previously: Feature flag was not available
  • To verify: Load flipper admin page and confirm flag is available
  • Tests completed: Manual testing to confirm flag is available

Screenshots

Screen Shot 2023-02-23 at 8 25 40 AM

What areas of the site does it impact?

No impact. Flipper flag is available but not in use yet.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

My first PR at VA! Please be gentle! 🙇‍♀️

Copy link
Contributor

@bosawt bosawt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@holytoastr holytoastr merged commit 677bf7c into master Feb 27, 2023
@holytoastr holytoastr deleted the 53789-feature-toggle-for-organic-login-adoption branch February 27, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants