Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update appointment date range #11883

Merged
merged 0 commits into from
Feb 23, 2023
Merged

Conversation

aherzberg
Copy link
Contributor

@aherzberg aherzberg commented Feb 23, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

It was found that VAOS defaults appointments index by looking 390 days in the future while we only look 1 year in the future. To help create a consistent experience, this updates ours 390 days as well.

Related issue(s)

department-of-veterans-affairs/va-mobile-app#4903

Testing done

specs

Screenshots

Note: Optional

What areas of the site does it impact?

Mobile only

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to 4903-appointment-range-increase/main/main February 23, 2023 16:50 Inactive
@aherzberg aherzberg marked this pull request as ready for review February 23, 2023 17:00
@aherzberg aherzberg requested review from a team as code owners February 23, 2023 17:00
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon second thought... the one other thing you need to do is change test descriptions, which currently say "one year from now".

@aherzberg
Copy link
Contributor Author

Upon second thought... the one other thing you need to do is change test descriptions, which currently say "one year from now".

good catch. fixed

@aherzberg aherzberg requested a review from kpethtel February 23, 2023 19:53
@va-vfs-bot va-vfs-bot temporarily deployed to 4903-appointment-range-increase/main/main February 23, 2023 19:53 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 4903-appointment-range-increase/main/main February 23, 2023 21:59 Inactive
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants