Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse direct deposit #11896

Merged
merged 0 commits into from
Mar 1, 2023
Merged

Lighthouse direct deposit #11896

merged 0 commits into from
Mar 1, 2023

Conversation

tpharrison
Copy link
Contributor

@tpharrison tpharrison commented Feb 24, 2023

Summary

Add direct deposit service for calling Lighthouse API. Here is the ticket.

@tpharrison
Copy link
Contributor Author

@jerekshoe Take a look when you get a chance...still a few things to do and change, but I think its better if we start reviewing now rather than later. Thanks!

@github-actions
Copy link

github-actions bot commented Feb 24, 2023

1 Warning
⚠️ This PR changes 490 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • config/settings.yml (+2/-1)

  • lib/lighthouse/direct_deposit/base.rb (+16/-0)

  • lib/lighthouse/direct_deposit/configuration.rb (+102/-0)

  • lib/lighthouse/direct_deposit/control_information.rb (+40/-0)

  • lib/lighthouse/direct_deposit/error.rb (+52/-0)

  • lib/lighthouse/direct_deposit/financial_institution.rb (+87/-0)

  • lib/lighthouse/direct_deposit/payment_account.rb (+26/-0)

  • lib/lighthouse/direct_deposit/response.rb (+29/-0)

  • lib/lighthouse/direct_deposit/service.rb (+47/-0)

  • spec/lib/lighthouse/direct_deposit/service_spec.rb (+88/-0)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to lighthouse-direct-deposit/main/main February 24, 2023 18:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to lighthouse-direct-deposit/main/main February 27, 2023 15:35 Inactive
@tpharrison tpharrison marked this pull request as ready for review February 27, 2023 16:11
@tpharrison tpharrison requested review from a team as code owners February 27, 2023 16:11
@tpharrison tpharrison merged commit 13ae813 into master Mar 1, 2023
@tpharrison tpharrison deleted the lighthouse-direct-deposit branch March 1, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants