Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaNotify - Add confirmation email to 1990 #11900

Merged
merged 0 commits into from
Feb 28, 2023

Conversation

nathanbwright
Copy link
Contributor

Summary

  • Adds confirmation email to form 1990
  • Sending email is behind a feature flag which will be removed once once we have incrementally rolled this out and verified that it is working as expected.

Related issue(s)

Testing done

  • Rspec
  • Will test manually in staging before releasing to prod

Screenshots

Note: Optional

What areas of the site does it impact?

Kicks off an sidekiq job to send an email confirmation to veterans when they have successfully submitted a 5490 form.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@nathanbwright nathanbwright requested review from a team as code owners February 25, 2023 00:18
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 25, 2023 00:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 25, 2023 00:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 27, 2023 16:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 27, 2023 18:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 27, 2023 20:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 27, 2023 20:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to vanotify-765/1990-confirmation-email/main/main February 27, 2023 22:03 Inactive
@nathanbwright nathanbwright merged commit df6a060 into master Feb 28, 2023
@nathanbwright nathanbwright deleted the vanotify-765/1990-confirmation-email branch February 28, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants