Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-23273-handling-can-claims #11908

Merged
merged 0 commits into from
Feb 28, 2023
Merged

API-23273-handling-can-claims #11908

merged 0 commits into from
Feb 28, 2023

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Includes "Canceled" as a valid claim status to be returned for both /claims and /claims/{id}
  • Updates schema documentation to include "Canceled" as a possible status to be returned in the enum
  • Updates OAS documentation for status descriptions to include the canceled status, UX will review as well

Related issue(s)

Testing done

What areas of the site does it impact?

vets-api

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stiehlrod stiehlrod merged commit fe74a9b into master Feb 28, 2023
@stiehlrod stiehlrod deleted the API-23273-handling-can-claims branch February 28, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants