Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add file_number toggle #11921

Merged
merged 0 commits into from
Feb 28, 2023
Merged

add file_number toggle #11921

merged 0 commits into from
Feb 28, 2023

Conversation

FonzMP
Copy link
Contributor

@FonzMP FonzMP commented Feb 28, 2023

Summary

  • Flipper feature for new file_number check to be introduced

Related issue(s)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@FonzMP FonzMP added the claimsApi modules/claims_api label Feb 28, 2023
@FonzMP FonzMP requested a review from cilestin February 28, 2023 17:09
@FonzMP FonzMP requested review from a team as code owners February 28, 2023 17:09
@va-vfs-bot va-vfs-bot temporarily deployed to claims_flipper_faraday_v2/main/main February 28, 2023 17:18 Inactive
@FonzMP FonzMP merged commit b208852 into master Feb 28, 2023
@FonzMP FonzMP deleted the claims_flipper_faraday_v2 branch February 28, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiehlrod stiehlrod stiehlrod approved these changes

@cilestin cilestin Awaiting requested review from cilestin

Assignees
No one assigned
Labels
claimsApi modules/claims_api console-services-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FonzMP @stiehlrod @va-vfs-bot