[45352] remove MHV Accounts

[bramleyjl]

Summary

• (Summarize the changes that have been made to the platform)
  • This PR removes the backend code controlling MHV Accounts. The feature has been determined to no longer be in use, and following the MHVA Accounts removal from vets-website its related code can now safely be removed from vets-api.
• (Which team do you work for, does your team own the maintainence of this component?)
  • Identity, neither of these features have specific codeowners.

Related issue(s)

• Get rid of MHV accounts in usercontroller va.gov-team#45352
• [FE] (Tech Debt) - Remove MHV Accounts (CTA) from vets-website va.gov-team#53362
• [FE] (Tech Debt) - Remove Terms & Conditions from vets-website va.gov-team#53360

Testing done

• SiS & SSOe authentications & user profile lookups performed without error.
• Unit specs for removed code also removed.

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

[github-actions]

1 Error

🚫

This PR changes 1399 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, those exceeding 500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into smaller ones. If you have reason to believe that this PR should be granted an exception, please see the Submitting pull requests for approval - FAQ. File Summary Files .rubocop.yml (+0/-1) app/controllers/v0/mhv_accounts_controller.rb (+0/-47) app/models/mhv_account.rb (+0/-230) app/models/mhv_account_ineligible.rb (+0/-31) app/models/terms_and_conditions_acceptance.rb (+0/-1) app/models/user.rb (+0/-7) app/policies/mhv_account_creation_policy.rb (+0/-7) app/serializers/mhv_account_serializer.rb (+0/-11) app/services/mhv_accounts_service.rb (+0/-139) app/services/users/services.rb (+0/-1) app/workers/mhv/account_statistics_job.rb (+0/-53) config/redis.yml (+0/-3) config/routes.rb (+0/-4) spec/controllers/v1/sessions_controller_spec.rb (+0/-2) spec/factories/mhv_accounts.rb (+0/-22) spec/jobs/mhv/account_statistics_job_spec.rb (+0/-50) spec/models/mhv_account_spec.rb (+0/-332) spec/requests/mhv_accounts_request_spec.rb (+0/-287) spec/requests/swagger_spec.rb (+0/-7) spec/requests/user_request_spec.rb (+0/-6) spec/services/mhv_accounts_service_spec.rb (+0/-156) spec/services/mhv_logging_service_spec.rb (+0/-2) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rileyanderson]

Looks good to me. Tested authentication locally

[rileyanderson]

🚀