Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-22649-new-526-endpoints #11938

Merged
merged 0 commits into from
Mar 1, 2023
Merged

API-22649-new-526-endpoints #11938

merged 0 commits into from
Mar 1, 2023

Conversation

stiehlrod
Copy link
Contributor

Summary

  • Adds the following endpoints for 526:
    post '/:veteranId/526', to: 'disability_compensation#submit'
    post '/:veteranId/526/validate', to: 'disability_compensation#validate'
    post '/:veteranId/526/attachments', to: 'disability_compensation#attachments'

Related issue(s)

Testing done

  • Rspec

What areas of the site does it impact?

vets-api

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod merged commit 7f7b142 into master Mar 1, 2023
@stiehlrod stiehlrod deleted the API-22649-new-526-endpoints branch March 1, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants