Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-24442-consent-addr-change #11939

Merged
merged 0 commits into from
Mar 2, 2023
Merged

API-24442-consent-addr-change #11939

merged 0 commits into from
Mar 2, 2023

Conversation

stiehlrod
Copy link
Contributor

Summary

  • adds log to track whenever consumers are setting it to true

Related issue(s)

Testing done

  • Rspec

What areas of the site does it impact?

vets-api

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels Mar 1, 2023
@stiehlrod stiehlrod self-assigned this Mar 1, 2023
@stiehlrod stiehlrod requested review from a team as code owners March 1, 2023 15:35
@va-vfs-bot va-vfs-bot temporarily deployed to API-24442-consent-addr-change/main/main March 1, 2023 15:45 Inactive
acovrig
acovrig previously approved these changes Mar 1, 2023
View reviewed changes
@va-vfs-bot va-vfs-bot temporarily deployed to API-24442-consent-addr-change/main/main March 1, 2023 21:32 Inactive
@stiehlrod stiehlrod merged commit 48d7273 into master Mar 2, 2023
@stiehlrod stiehlrod deleted the API-24442-consent-addr-change branch March 2, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acovrig acovrig acovrig approved these changes

Assignees

@stiehlrod stiehlrod

Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stiehlrod @acovrig @va-vfs-bot