Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-23731 remove /v0/mvi-user items #11941

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Conversation

crolarlibertyva
Copy link
Contributor

@crolarlibertyva crolarlibertyva commented Mar 1, 2023

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • There is no consumer for "internal/auth/v0/mvi-user"
  • It is now removed as well as docs and specs.

Related issue(s)

Testing done

  • Verified the endpoint is removed.

Screenshots

{
    "errors": [
        {
            "title": "Not found",
            "detail": "There are no routes matching your request: internal/auth/v0/mvi-user",
            "code": "411",
            "status": "404"
        }
    ]
}

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@crolarlibertyva crolarlibertyva requested review from a team as code owners March 1, 2023 20:05
@crolarlibertyva crolarlibertyva changed the title API-23731 rm /v0/mvi-user items API-23731 remove /v0/mvi-user items Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

1 Warning
⚠️ This PR changes 393 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/openid_auth/app/controllers/openid_auth/docs/v0/mpi_users_controller.rb (+0/-16)

  • modules/openid_auth/app/controllers/openid_auth/v0/mpi_users_controller.rb (+0/-90)

  • modules/openid_auth/config/routes.rb (+0/-5)

  • modules/openid_auth/spec/requests/api_docs_request_spec.rb (+0/-8)

  • modules/openid_auth/spec/requests/mpi_user_request_spec.rb (+0/-274)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to API-23731-rm-mvi-v0/main/main March 1, 2023 20:06 Inactive
Copy link
Contributor

@dbrown-va dbrown-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no remaining traffic after transitioning to new service.

image

@crolarlibertyva crolarlibertyva merged commit 674256a into master Mar 3, 2023
@crolarlibertyva crolarlibertyva deleted the API-23731-rm-mvi-v0 branch March 3, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants