Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api and worker namespaces to UAVC StatsD keys #11942

Merged
merged 0 commits into from
Mar 1, 2023

Conversation

rileyanderson
Copy link
Contributor

@rileyanderson rileyanderson commented Mar 1, 2023

Summary

  • Datadog was not receiving stats. Add api and worker namespaces which are whitelisted namespaces.

Testing done

  • Updated specs
  • Ran Sidekiq cron locally, correct key was set.
  • Tested auth locally with a user with no UserAcceptableVerifiedCredentials, correct statds D key incremented

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@rileyanderson rileyanderson merged commit c6b51e3 into master Mar 1, 2023
@rileyanderson rileyanderson deleted the update-uavc-statsd-prefix branch March 1, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants