Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 24397 faraday bgs ssn #11943

Merged
merged 0 commits into from
Mar 1, 2023
Merged

Api 24397 faraday bgs ssn #11943

merged 0 commits into from
Mar 1, 2023

Conversation

FonzMP
Copy link
Contributor

@FonzMP FonzMP commented Mar 1, 2023

Summary

  • Introduces the ssn request from bgs-ext to use the new Faraday connection.

Related issue(s)

Testing done

  • RSPEC Updated
  • Tested locally using flipper and staging fwdproxy

What areas of the site does it impact?

Claims API

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@FonzMP FonzMP added the claimsApi modules/claims_api label Mar 1, 2023
@FonzMP FonzMP requested a review from cilestin March 1, 2023 20:57
@FonzMP FonzMP requested review from a team as code owners March 1, 2023 20:57
stiehlrod
stiehlrod approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested together, so LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to API-24397_faraday_bgs_ssn/main/main March 1, 2023 21:04 Inactive
@FonzMP FonzMP merged commit 8944c00 into master Mar 1, 2023
@FonzMP FonzMP deleted the API-24397_faraday_bgs_ssn branch March 1, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiehlrod stiehlrod stiehlrod approved these changes

@cilestin cilestin Awaiting requested review from cilestin

Assignees
No one assigned
Labels
claimsApi modules/claims_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FonzMP @stiehlrod @va-vfs-bot