Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duration logging to LocalBGS service #11947

Merged
merged 0 commits into from
Mar 2, 2023
Merged

Add duration logging to LocalBGS service #11947

merged 0 commits into from
Mar 2, 2023

Conversation

cilestin
Copy link
Contributor

@cilestin cilestin commented Mar 2, 2023

Summary

Adds duration logging to connection & parsing calls in the ClaimsApi::LocalBGS service.
Includes rails logging & statsd measuring

Related issue(s)

https://vajira.max.gov/browse/API-22589

Testing done

  • Local running & unit test creation

What areas of the site does it impact?

LocalBGS service, currently gated behind a feature flag

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@cilestin cilestin added Lighthouse lighthouse claimsApi modules/claims_api labels Mar 2, 2023
@cilestin cilestin requested review from a team as code owners March 2, 2023 03:28
@va-vfs-bot va-vfs-bot temporarily deployed to localbgs-logging/main/main March 2, 2023 03:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to localbgs-logging/main/main March 2, 2023 03:42 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to localbgs-logging/main/main March 2, 2023 03:47 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to localbgs-logging/main/main March 2, 2023 04:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to localbgs-logging/main/main March 2, 2023 04:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to localbgs-logging/main/main March 2, 2023 04:16 Inactive
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cilestin cilestin merged commit b265811 into master Mar 2, 2023
@cilestin cilestin deleted the localbgs-logging branch March 2, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants