Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 KwArgs: fix emis_redis spec #11955

Merged
merged 0 commits into from
Mar 2, 2023
Merged

Ruby 3 KwArgs: fix emis_redis spec #11955

merged 0 commits into from
Mar 2, 2023

Conversation

holdenhinkle
Copy link
Contributor

Ruby 2.7 deprecated automatic casting of a hash passed as the last argument of a method to keyword arguments. You must now use actual keyword arguments (foo(bar: 'baz') instead of foo({bar: 'baz'})) or cast the hash to keyword args using the double splat (foo(**{bar: 'baz'})).

lib/emis/service.rb Outdated Show resolved Hide resolved
lib/emis/service.rb Outdated Show resolved Hide resolved
@va-vfs-bot va-vfs-bot temporarily deployed to fix_emis_redis_spec/main/main March 2, 2023 18:17 Inactive
@holdenhinkle holdenhinkle requested a review from ericboehs March 2, 2023 18:21
@holdenhinkle holdenhinkle marked this pull request as ready for review March 2, 2023 18:30
@holdenhinkle holdenhinkle requested review from a team as code owners March 2, 2023 18:30
@ericboehs ericboehs merged commit a1141f4 into master Mar 2, 2023
@ericboehs ericboehs deleted the fix_emis_redis_spec branch March 2, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants