Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 24720 validation consolidation #11975

Merged
merged 0 commits into from
Mar 7, 2023

Conversation

mchristiansonVA
Copy link
Contributor

@mchristiansonVA mchristiansonVA commented Mar 5, 2023

Summary

  • Refactored logic in controller and validator classes such that the same validation is applied for calls to /validate and /intent-to-file endpoints.

Related issue(s)

API-24720

Testing done

  • Tested with Postman to confirm the same validation is applied for calls to /validate and /intent-to-file.
  • Tested with Postman to confirm all ITF endpoints are working as expected, and calls passing validation are successful.
  • Added a new rspec test to confirm valid SSN parameter with hyphens is correctly handled.

What areas of the site does it impact?

  • Vets.api Benefits Claims ITF endpoints.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels Mar 5, 2023
@mchristiansonVA mchristiansonVA self-assigned this Mar 5, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-24720_validation_consolidation/main/main March 5, 2023 16:59 Inactive
@mchristiansonVA mchristiansonVA mentioned this pull request Mar 5, 2023
8 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to API-24720_validation_consolidation/main/main March 5, 2023 18:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24720_validation_consolidation/main/main March 6, 2023 15:41 Inactive
@mchristiansonVA mchristiansonVA marked this pull request as ready for review March 6, 2023 17:07
@mchristiansonVA mchristiansonVA requested review from a team as code owners March 6, 2023 17:07
@mchristiansonVA mchristiansonVA merged commit a315845 into master Mar 7, 2023
@mchristiansonVA mchristiansonVA deleted the API-24720_validation_consolidation branch March 7, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants