Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

39154 pt1 remove v0 implementations from vets api v0 facilities controller #11990

Merged
merged 0 commits into from
Mar 7, 2023
Merged

39154 pt1 remove v0 implementations from vets api v0 facilities controller #11990

merged 0 commits into from
Mar 7, 2023

Conversation

ajmagdub
Copy link
Contributor

@ajmagdub ajmagdub commented Mar 6, 2023 •
edited
Loading

Summary

Removed VAOS V0 Facilities Controller implementation and partially (to keep under LOC count check) removed Facilities Controller request rspecs.

Related issue(s)

department-of-veterans-affairs/va.gov-team#39154

@github-actions github-actions bot added the VAOS Va Online Scheduling Contract label Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023 •
edited
Loading

1 Warning
⚠️ This PR changes 256 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/vaos/app/controllers/vaos/v0/facilities_controller.rb (+0/-38)

  • modules/vaos/spec/request/facilities_request_spec.rb (+0/-218)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vfs-bot va-vfs-bot temporarily deployed to 39154-pt1-remove-v0-implementations-from-vets-api-v0-facilities-controller/main/main March 6, 2023 23:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 39154-pt1-remove-v0-implementations-from-vets-api-v0-facilities-controller/main/main March 7, 2023 15:10 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 39154-pt1-remove-v0-implementations-from-vets-api-v0-facilities-controller/main/main March 7, 2023 17:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 39154-pt1-remove-v0-implementations-from-vets-api-v0-facilities-controller/main/main March 7, 2023 17:58 Inactive
@ajmagdub ajmagdub marked this pull request as ready for review March 7, 2023 20:23
@ajmagdub ajmagdub requested review from a team as code owners March 7, 2023 20:23
cferris32
cferris32 approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@cferris32 cferris32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajmagdub ajmagdub merged commit 42d97a8 into master Mar 7, 2023
@ajmagdub ajmagdub deleted the 39154-pt1-remove-v0-implementations-from-vets-api-v0-facilities-controller branch March 7, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferris32 cferris32 cferris32 approved these changes

Assignees
No one assigned
Labels
VAOS Va Online Scheduling Contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajmagdub @cferris32 @va-vfs-bot