Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 24327 multiple pids #12087

Merged
merged 0 commits into from
Mar 23, 2023
Merged

Api 24327 multiple pids #12087

merged 0 commits into from
Mar 23, 2023

Conversation

acovrig
Copy link
Contributor

@acovrig acovrig commented Mar 13, 2023

Summary

  • If a veteran's MPI profile has multiple active participant IDs, return a 422.

Related issue(s)

Testing done

  • rspec

What areas of the site does it impact?

claims_api/v1

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@acovrig acovrig requested review from a team as code owners March 13, 2023 20:59
@acovrig acovrig marked this pull request as draft March 13, 2023 20:59
@acovrig acovrig requested review from stiehlrod and FonzMP March 13, 2023 20:59
@acovrig acovrig self-assigned this Mar 13, 2023
@acovrig acovrig added Lighthouse lighthouse claimsApi modules/claims_api labels Mar 13, 2023
@acovrig acovrig marked this pull request as ready for review March 13, 2023 21:00
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 13, 2023 21:33 Inactive
@acovrig acovrig changed the title Api 24327 multiple pi ds Api 24327 multiple pids Mar 13, 2023
mchristiansonVA
mchristiansonVA previously approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down branch and stepped-through locally with debugger; confirmed multiple participant ids case is handled and HTTP 422 returned as expected.

acovrig
acovrig commented Mar 14, 2023
View reviewed changes
app/models/mpi_data.rb Outdated
@@ -236,6 +236,7 @@ def add_ids(response)
profile.birls_id = response.parsed_codes[:birls_id].presence
profile.participant_id = response.parsed_codes[:participant_id].presence

profile.participant_ids = profile.participant_ids.push(profile.participant_id).uniq
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line actually do anything? When accessing target_veteran.participant_ids later, the PID from the ICN lookup isn't in that list (hence the push here).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that we achieve the goal without this addition

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the decision here? do we need this?

@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 14, 2023 17:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 15, 2023 14:56 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 17, 2023 18:16 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 20, 2023 15:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 20, 2023 18:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 21, 2023 20:37 Inactive
@acovrig acovrig force-pushed the API-24327-multiple-PIDs branch from 672d14d to bdf880d Compare March 21, 2023 20:44
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 21, 2023 20:53 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 22, 2023 22:34 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 23, 2023 15:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 23, 2023 15:38 Inactive
stiehlrod
stiehlrod previously approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, v2 next?

@va-vfs-bot va-vfs-bot temporarily deployed to API-24327-multiple-PIDs/main/main March 23, 2023 17:07 Inactive
@acovrig acovrig merged commit 1090647 into master Mar 23, 2023
@acovrig acovrig deleted the API-24327-multiple-PIDs branch March 23, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FonzMP FonzMP FonzMP left review comments

@stiehlrod stiehlrod stiehlrod approved these changes

@mchristiansonVA mchristiansonVA mchristiansonVA left review comments

Assignees

@acovrig acovrig

Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@acovrig @stiehlrod @FonzMP @mchristiansonVA @va-vfs-bot