Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4743: change mobile lighthouse letters client id to match new key #12172

Merged
merged 0 commits into from
Apr 19, 2023

Conversation

kpethtel
Copy link
Contributor

Summary

  • Changes mobile lighthouse letters config to use new key client id

Related issue(s)

https://app.zenhub.com/workspaces/va-mobile---backend-61d75d03a7505500147ec7f6/issues/gh/department-of-veterans-affairs/va-mobile-app/4743

Testing done

Screenshots

Note: Optional

What areas of the site does it impact?

None at this time because we're not yet using this api key.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@kpethtel kpethtel marked this pull request as ready for review March 20, 2023 17:36
@kpethtel kpethtel requested review from a team as code owners March 20, 2023 17:36
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main March 20, 2023 17:39 Inactive
@kpethtel kpethtel requested a review from aherzberg March 20, 2023 21:55
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main March 21, 2023 13:22 Inactive
@@ -1440,13 +1440,7 @@ lighthouse_health_immunization:
- "patient/Location.read"

mobile_lighthouse_letters:
client_id: '0oajpx78t3M8kurld2p7'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're working with the letters team and they're adding their own keys which will contain all of this info. We only need client id. The plan is to use our client id when making calls so that the lighthouse team knows who's using the API.

rjohnson2011
rjohnson2011 previously approved these changes Mar 21, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main March 23, 2023 22:01 Inactive
@kpethtel kpethtel requested a review from rjohnson2011 March 23, 2023 22:12
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main March 24, 2023 12:38 Inactive
rjohnson2011
rjohnson2011 previously approved these changes Mar 24, 2023
@va-vsp-bot va-vsp-bot requested a deployment to master/main/4743-change-lighthouse-api-client-id March 30, 2023 17:49 In progress
@aherzberg aherzberg requested a review from a team as a code owner March 31, 2023 16:03
@va-vsp-bot va-vsp-bot requested a deployment to master/main/4743-change-lighthouse-api-client-id March 31, 2023 16:03 In progress
@va-vsp-bot va-vsp-bot requested a deployment to master/main/4743-change-lighthouse-api-client-id March 31, 2023 16:23 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main April 3, 2023 14:17 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/4743-change-lighthouse-api-client-id April 3, 2023 15:57 In progress
@va-vsp-bot va-vsp-bot requested a deployment to master/main/4743-change-lighthouse-api-client-id April 3, 2023 19:31 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main April 3, 2023 19:32 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/4743-change-lighthouse-api-client-id April 10, 2023 15:56 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 4743-change-lighthouse-api-client-id/main/main April 10, 2023 15:58 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 4743-change-lighthouse-api-client-id/main/main April 19, 2023 16:39 In progress
@aherzberg aherzberg merged commit abbca2d into master Apr 19, 2023
@aherzberg aherzberg deleted the 4743-change-lighthouse-api-client-id branch April 19, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants