-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4743: change mobile lighthouse letters client id to match new key #12172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
March 20, 2023 17:39
Inactive
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
March 21, 2023 13:22
Inactive
kpethtel
commented
Mar 21, 2023
@@ -1440,13 +1440,7 @@ lighthouse_health_immunization: | |||
- "patient/Location.read" | |||
|
|||
mobile_lighthouse_letters: | |||
client_id: '0oajpx78t3M8kurld2p7' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're working with the letters team and they're adding their own keys which will contain all of this info. We only need client id. The plan is to use our client id when making calls so that the lighthouse team knows who's using the API.
rjohnson2011
previously approved these changes
Mar 21, 2023
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
March 23, 2023 22:01
Inactive
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
March 24, 2023 12:38
Inactive
rjohnson2011
previously approved these changes
Mar 24, 2023
2 tasks
va-vsp-bot
requested a deployment
to
master/main/4743-change-lighthouse-api-client-id
March 30, 2023 17:49
In progress
va-vsp-bot
requested a deployment
to
master/main/4743-change-lighthouse-api-client-id
March 31, 2023 16:03
In progress
va-vsp-bot
requested a deployment
to
master/main/4743-change-lighthouse-api-client-id
March 31, 2023 16:23
In progress
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
April 3, 2023 14:17
Inactive
va-vsp-bot
requested a deployment
to
master/main/4743-change-lighthouse-api-client-id
April 3, 2023 15:57
In progress
va-vsp-bot
requested a deployment
to
master/main/4743-change-lighthouse-api-client-id
April 3, 2023 19:31
In progress
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
April 3, 2023 19:32
Inactive
va-vsp-bot
requested a deployment
to
master/main/4743-change-lighthouse-api-client-id
April 10, 2023 15:56
In progress
va-vfs-bot
temporarily deployed
to
4743-change-lighthouse-api-client-id/main/main
April 10, 2023 15:58
Inactive
rjohnson2011
approved these changes
Apr 10, 2023
va-vsp-bot
requested a deployment
to
4743-change-lighthouse-api-client-id/main/main
April 19, 2023 16:39
In progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
https://app.zenhub.com/workspaces/va-mobile---backend-61d75d03a7505500147ec7f6/issues/gh/department-of-veterans-affairs/va-mobile-app/4743
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
None at this time because we're not yet using this api key.
Acceptance criteria
Requested Feedback