API-24936-bgs-local-tracked-items #12194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
API-24936-bgs-local-tracked-items/main/main
acovrig
reviewed
Mar 23, 2023
Comment on lines
148
to
150
| { claimId: id }.each do |k, v| | ||
| body.xpath("./*[local-name()='#{k}']")[0].content = v | ||
| end |
There was a problem hiding this comment.
I wonder if we could make this a helper method or something since every call will need it? That being said, I feel like code can be too dry...
acovrig
reviewed
Mar 23, 2023
| raise ::Common::Exceptions::ResourceNotFound.new(detail: 'Claim tracked items not found') | ||
| end | ||
|
|
||
| raise |
There was a problem hiding this comment.
Probably fine for now, but it'd be nice to have more error handling down the road as I'm sure we'll find more errors (I.E. connection timeout or a non-200 response).
acovrig
previously approved these changes
Mar 23, 2023
acovrig
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we have identified the Claims API latency issue to be related to the bgs-ext gem, we will need to move our BGS services for tracked items to Faraday as well.
Acceptance Criteria:
Move /findTrackedItems to Faraday
Related issue(s)