Bdex/54161: Migrate eVSS calls to rated disabilities functionality (vets-api /rated_disabilities)

[sethdarragile6]

Summary

• This PR migrates eVSS calls to rated disabilities functionality to Lighthouse (or any provider!)
• Created by: Benefit Delivery Experience team
• Flipper switch 'disability_compensation_lighthouse_rated_disabilities_provider' should be enabled when LH migration goes live, then removed once functionality is verified

Related issue(s)

• 54161

Testing done

• Unit tests for factory, provider and service created. Also manually tested via Postman and using the local instance of vets-website

What areas of the site does it impact?

Disability claims

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 332 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files app/controllers/v0/disability_compensation_forms_controller.rb (+1/-8) app/controllers/v0/disability_compensation_in_progress_forms_controller.rb (+5/-5) app/models/form_profiles/va_526ez.rb (+3/-2) config/settings.yml (+7/-0) config/settings/test.yml (+7/-0) lib/disability_compensation/factories/api_provider_factory.rb (+11/-3) lib/disability_compensation/providers/rated_disabilities/lighthouse_rated_disabilities_provider.rb (+35/-3) lib/lighthouse/auth/client_credentials/service.rb (+4/-4) lib/lighthouse/veteran_verification/configuration.rb (+96/-0) lib/lighthouse/veteran_verification/service.rb (+21/-0) lib/lighthouse/veteran_verification/service_exception.rb (+28/-0) spec/lib/disability_compensation/factories/api_provider_factory_spec.rb (+14/-6) spec/lib/disability_compensation/providers/lighthouse_rated_disabilities_provider_spec.rb (+1/-7) spec/lib/lighthouse/veteran_verification/service_spec.rb (+30/-0) spec/models/form_profile_spec.rb (+7/-0) spec/requests/disability_compensation_form_request_spec.rb (+21/-1) spec/requests/v0/disability_compensation_in_progress_forms_controller_request_spec.rb (+2/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[christinec-fftc]

The team had a pairing session where we walked through this pr together. lgtm!

[mchae-nava]

Took a pass clicking through, LGTM! Minor considerations, more for future thought

• Minor comments/checks on tests
• If I remember, there was a lot of discussion on the ticket tracking this work, and some shifts on how we approached this. Might be good to include a light context in the PR description, as well as any steps planned in the near future following this work

[mchae-nava]

Just marking here to note the comment I made yesterday about testing coverage, and that this could be made more robust by making sure the incorrect provider is not active, especially if the check is for a behavior

[ryan-mcneil]

Thanks for the additional reviews! 🚀