Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5086 verify military access in controller #12252

Merged
merged 0 commits into from
Mar 27, 2023
Merged

5086 verify military access in controller #12252

merged 0 commits into from
Mar 27, 2023

Conversation

cadibemma
Copy link
Contributor

Summary

  • The military information controller should confirm that the user can use the vet360 service

Related issue(s)

Testing done

  • Added test for 403 response

What areas of the site does it impact?

  • None

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@cadibemma cadibemma requested review from a team as code owners March 24, 2023 19:50
@va-vfs-bot va-vfs-bot temporarily deployed to 5086-verify-military-access-in-controller/main/main March 24, 2023 19:55 Inactive
aherzberg
aherzberg previously approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kpethtel
kpethtel requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to have this VCR because the outbound call is never made. I'd recommend removing the VCR you copied over because it's never actually used.

@va-vfs-bot va-vfs-bot temporarily deployed to 5086-verify-military-access-in-controller/main/main March 24, 2023 20:32 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/5086-verify-military-access-in-controller March 24, 2023 20:33 In progress
@cadibemma cadibemma requested a review from kpethtel March 24, 2023 20:34
@va-vsp-bot va-vsp-bot requested a deployment to master/main/5086-verify-military-access-in-controller March 24, 2023 21:59 In progress
@cadibemma cadibemma requested a review from kpethtel March 24, 2023 21:59
@cadibemma cadibemma enabled auto-merge (squash) March 24, 2023 22:00
@cadibemma cadibemma requested a review from aherzberg March 27, 2023 21:16
aherzberg
aherzberg approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@aherzberg aherzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I always forget the policies will prevent the VCRs from running.

@cadibemma cadibemma merged commit 3e66962 into master Mar 27, 2023
@cadibemma cadibemma deleted the 5086-verify-military-access-in-controller branch March 27, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherzberg aherzberg aherzberg approved these changes

@kpethtel kpethtel Awaiting requested review from kpethtel

Assignees
No one assigned
Labels
mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cadibemma @aherzberg @kpethtel @va-vfs-bot @va-vsp-bot