Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

55882 Update travel claim controller to call background worker #12371

Merged
merged 0 commits into from
Apr 17, 2023

Conversation

randomsync
Copy link
Member

@randomsync randomsync commented Apr 10, 2023

Summary

This PR updates the CheckIn TravelClaims controller to call the background worker to submit claims and send a notification, instead of calling the BTSSS api directly. The background worker is still a WIP, and is being handled in a separate PR.

Related issue(s)

Testing done

  • rspecs
  • local testing

What areas of the site does it impact?

  • travel claims submission as part of check-in workflow

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.

@randomsync randomsync marked this pull request as ready for review April 10, 2023 21:07
@randomsync randomsync requested review from a team as code owners April 10, 2023 21:07
@randomsync randomsync force-pushed the 55882_travel_claims_controller_async branch from cae1bf4 to 733ae77 Compare April 10, 2023 21:08
@va-vsp-bot va-vsp-bot requested a deployment to master/main/55882_travel_claims_controller_async April 10, 2023 21:08 In progress
Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@randomsync randomsync merged commit 0b0731c into master Apr 17, 2023
@randomsync randomsync deleted the 55882_travel_claims_controller_async branch April 17, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants