Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 25719 current phase back #12380

Merged
merged 0 commits into from
Apr 17, 2023
Merged

Conversation

mchristiansonVA
Copy link
Contributor

@mchristiansonVA mchristiansonVA commented Apr 11, 2023

Summary

  • Updates the logic for v2 ClaimController methods current_phase_back and get_phase_type_indicator_array so that they function correctly given the BGS claim details data structure.

Related issue(s)

API-25719

Testing done

  • Previously both methods always returned false regardless of the actual BGS data returned.
  • Manual tests with Postman and debugger.
  • ICN = 1012830905V768518, claimID = 600382810
  • Added new rspec test and associated factory elements to validate that the updated methods are working correctly and that the related claim phase date data attributes return expected values.

What areas of the site does it impact?

  • Claims v2 Show route

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels Apr 11, 2023
@mchristiansonVA mchristiansonVA requested review from a team as code owners April 11, 2023 17:45
@mchristiansonVA mchristiansonVA self-assigned this Apr 11, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-25719-current-phase-back/main/main April 11, 2023 17:52 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/API-25719-current-phase-back April 12, 2023 16:37 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25719-current-phase-back/main/main April 12, 2023 16:42 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/API-25719-current-phase-back April 12, 2023 16:42 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25719-current-phase-back/main/main April 12, 2023 16:47 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/API-25719-current-phase-back April 12, 2023 17:43 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25719-current-phase-back/main/main April 12, 2023 17:48 Inactive
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which ICN and claim_id/s did you use to test this?

@mchristiansonVA
Copy link
Contributor Author

Which ICN and claim_id/s did you use to test this?

As discussed in slack, I couldn't find a claim to test the current phaseback field directly, but was able to test using rspec & a debugger to exercise the logic and validate result.

@mchristiansonVA mchristiansonVA merged commit 89e2239 into master Apr 17, 2023
@mchristiansonVA mchristiansonVA deleted the API-25719-current-phase-back branch April 17, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants