add decision_letter_sent field to claims and appeals overview #12387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
5339-v1-claims-and-appeals/main/main
va-vsp-bot
requested a deployment
to
master/main/5339-v1-claims-and-appeals
va-vfs-bot
temporarily deployed
to
5339-v1-claims-and-appeals/main/main
va-vsp-bot
requested a deployment
to
master/main/5339-v1-claims-and-appeals
va-vfs-bot
temporarily deployed
to
5339-v1-claims-and-appeals/main/main
va-vsp-bot
requested a deployment
to
master/main/5339-v1-claims-and-appeals
va-vsp-bot
requested a deployment
to
master/main/5339-v1-claims-and-appeals
aherzberg
commented
Apr 12, 2023
| @@ -65,7 +66,8 @@ def parse_appeal(entry) | |||
| completed: !entry['attributes']['active'], | |||
| date_filed: entry['attributes']['events'][filed_index]['date'], | |||
| updated_at: entry['attributes']['events'].last['date'], | |||
| display_title: get_appeals_display_title(subtype, entry['attributes']['programArea']) | |||
| display_title: get_appeals_display_title(subtype, entry['attributes']['programArea']), | |||
| decision_letter_sent: false | |||
There was a problem hiding this comment.
appeal decision letters aren't included in decision letter listing right now. Will be added later.
va-vfs-bot
temporarily deployed
to
5339-v1-claims-and-appeals/main/main
va-vsp-bot
requested a deployment
to
master/main/5339-v1-claims-and-appeals
va-vsp-bot
requested a deployment
to
5339-v1-claims-and-appeals/main/main
kpethtel
previously approved these changes
Apr 18, 2023
| @@ -7,6 +7,7 @@ class ClaimsAndAppeals < PaginationBase | |||
| params(Schemas::DateRangeSchema) do | |||
| optional(:use_cache).maybe(:bool, :filled?) | |||
| optional(:show_completed).maybe(:bool, :filled?) | |||
| optional(:decision_letter_sent).maybe(:bool, :filled?) | |||
There was a problem hiding this comment.
Is this necessary? These contracts are for validating incoming params from the mobile client. Unless we're planning to filter based on this value, I doubt this is a controller param.
There was a problem hiding this comment.
oops. yeah that slipped in when I was trying to debug something and forgot to remove it. fixed
va-vsp-bot
requested a deployment
to
5339-v1-claims-and-appeals/main/main
va-vsp-bot
requested a deployment
to
5339-v1-claims-and-appeals/main/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
FE is adding a tag to index page of claims and appeals, this adds a field that will allow them to check if a claim or appeal has a decision letter.
Related issue(s)
department-of-veterans-affairs/va-mobile-app#5339
Testing done
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?