Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vfep 531 - fix 5490 spool file phone number order and school selection questions #12402

Merged
merged 0 commits into from
Apr 18, 2023

Conversation

GcioGregg
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • Vfep 531 - fix 5490 spool file phone number order and school selection questions
  • (If bug, how to reproduce) spool file has school selection questions and phone numbers in proper location
  • (What is the solution, why is this the solution) changes in spool file needed in order to match front end
  • (Which team do you work for, does your team own the maintainence of this component?) VFEP
  • environment flags to be removed upon user acceptance

Related issue(s)

  • department-of-veterans-affairs/va.gov-team#0000
  • [vfep-531] (https://vajiramax.gov/browser/vfep-531)
  • Link to previous change of the code/bug (if applicable) N/A
  • Link to epic if not included in ticket N/A

Testing done

  • Describe what the old behavior was prior to the change spool files had info in wrong location
  • Describe the steps required to verify your changes are working as expected review sample spool file after submitting form 5490
  • Describe the tests completed and the results all automated tests passed and UAT passed

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@GcioGregg GcioGregg requested review from a team as code owners April 13, 2023 20:42
@va-vfs-bot va-vfs-bot temporarily deployed to vfep-531/main/main April 13, 2023 20:43 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/vfep-531 April 13, 2023 20:48 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to vfep-531/main/main April 13, 2023 20:57 Inactive
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants