Remove sign-in service metrics from initializer #12415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Metrics initialized to 0 are causing issues with the new EKS implementation. The default type for metrics in datadog is
rate
(which EKS sends) butBRD
sets type tocount
. Metrics are still being initialized in BRD which is clashing with metrics being created in EKS causing frequent flipping betweencount
andrate
. Remove sign-in service metrics from the initializer as a test and then remove the initializer if it's not necessary anymore.Related issue(s)
Testing done
What areas of the site does it impact?
Sign-in Service metrics
Acceptance criteria