Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sign-in service metrics from initializer #12415

Merged
merged 0 commits into from
Apr 17, 2023

Conversation

rileyanderson
Copy link
Contributor

@rileyanderson rileyanderson commented Apr 17, 2023

Summary

Metrics initialized to 0 are causing issues with the new EKS implementation. The default type for metrics in datadog is rate (which EKS sends) but BRD sets type to count. Metrics are still being initialized in BRD which is clashing with metrics being created in EKS causing frequent flipping between count and rate. Remove sign-in service metrics from the initializer as a test and then remove the initializer if it's not necessary anymore.

Related issue(s)

Testing done

  • Tested metrics locally and they get incremented

What areas of the site does it impact?

Sign-in Service metrics

Acceptance criteria

  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

Copy link
Contributor

@LindseySaari LindseySaari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a shot!

@rileyanderson rileyanderson merged commit 4e4d670 into master Apr 17, 2023
@rileyanderson rileyanderson deleted the remove-sis-statsd-init branch April 17, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants