Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefill config for 21-4142 #12416

Merged
merged 0 commits into from
Apr 17, 2023
Merged

Add prefill config for 21-4142 #12416

merged 0 commits into from
Apr 17, 2023

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented Apr 17, 2023

Enable form prefill for 21-4142

Summary

  • Add form profile for 21-4142
  • Add config for 21-4142 prefill and mapping
  • Add tests

Related issue(s)

Testing done

  • Tested locally with frontend and backend. Prefilled all expected fields.

What areas of the site does it impact?

Form 21-4142 (not yet prod)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to forms_api_prefill_21-4142/main/main April 17, 2023 15:47 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to master/main/forms_api_prefill_21-4142 April 17, 2023 15:55 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to forms_api_prefill_21-4142/main/main April 17, 2023 16:00 Inactive
@gmrabian gmrabian marked this pull request as ready for review April 17, 2023 16:09
@gmrabian gmrabian requested review from a team as code owners April 17, 2023 16:09
@gmrabian gmrabian self-assigned this Apr 17, 2023
@va-vsp-bot va-vsp-bot requested a deployment to master/main/forms_api_prefill_21-4142 April 17, 2023 20:53 In progress
@gmrabian gmrabian enabled auto-merge (squash) April 17, 2023 21:09
@ryan-mcneil ryan-mcneil self-assigned this Apr 17, 2023
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmrabian gmrabian merged commit e4641ae into master Apr 17, 2023
@gmrabian gmrabian deleted the forms_api_prefill_21-4142 branch April 17, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants