Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove enable_in_development Key from Appeals Feature Flags #12418

Merged
merged 0 commits into from
Apr 17, 2023

Conversation

kristen-brown
Copy link
Contributor

Summary

After updating the values of a handful of Appeals feature flags in the development environment and then seeing the values change the next day, we eventually learned that the presence of enable_in_development: true in the feature flag config for these flags was overwriting the changes we had made to them in development.

Since we would like our changes to feature flags in dev to "stick," this PR removes enable_in_development: true from all Appeals (decision_reviews) feature flags.

Testing done

Was not able to test this change, but we expect the changes to these feature flags in the development environment to "stick" after this change is merged.

Screenshots

None

What areas of the site does it impact?

This PR impacts the decision_reviews feature flags in the development environment.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable). – N/A
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution – N/A
  • Documentation has been updated (link to documentation) – N/A
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable) – N/A
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected – N/A
  • I added a screenshot of the developed feature – N/A

Requested Feedback

No specific feedback requested.

@kristen-brown kristen-brown requested review from a team as code owners April 17, 2023 16:38
@kristen-brown kristen-brown added appeals Lighthouse API appeals banana-peels Lighthouse Banana Peels Team Lighthouse lighthouse and removed console-services-review appeals Lighthouse API appeals labels Apr 17, 2023
@kristen-brown kristen-brown reopened this Apr 17, 2023
Copy link
Contributor

@caseywilliams caseywilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I had no idea!

@kristen-brown kristen-brown merged commit adf00c9 into master Apr 17, 2023
@kristen-brown kristen-brown deleted the fix-appeals-dev-feature-flags branch April 17, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
banana-peels Lighthouse Banana Peels Team console-services-review Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants