Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing spec issue with loading certain files #12429

Merged
merged 0 commits into from
Apr 18, 2023
Merged

Fixing spec issue with loading certain files #12429

merged 0 commits into from
Apr 18, 2023

Conversation

bosawt
Copy link
Contributor

@bosawt bosawt commented Apr 17, 2023

Summary

  • This PR fixes an issue caused by a recent PR that prevented ton of spec files from being properly loaded, causing many spec errors

@bosawt bosawt requested review from a team as code owners April 17, 2023 22:59
@va-vfs-bot va-vfs-bot temporarily deployed to fix_spec_file_loading_issue/main/main April 17, 2023 23:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to fix_spec_file_loading_issue/main/main April 17, 2023 23:12 Inactive
@bosawt bosawt force-pushed the fix_spec_file_loading_issue branch from b57c1f5 to d690abc Compare April 17, 2023 23:50
@va-vsp-bot va-vsp-bot requested a deployment to master/main/fix_spec_file_loading_issue April 17, 2023 23:51 In progress
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Apr 18, 2023
Closed
@ryan-mcneil ryan-mcneil self-assigned this Apr 18, 2023
ryan-mcneil
ryan-mcneil approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! I was wondering why I couldn't get tests to pass 😆 . I'll pull master once its merged!

@bosawt bosawt enabled auto-merge (squash) April 18, 2023 00:14
@bosawt bosawt merged commit 8fcd4f1 into master Apr 18, 2023
@bosawt bosawt deleted the fix_spec_file_loading_issue branch April 18, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asg5704 asg5704 asg5704 approved these changes

@ryan-mcneil ryan-mcneil ryan-mcneil approved these changes

Assignees

@ryan-mcneil ryan-mcneil

Labels
console-services-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bosawt @ryan-mcneil @asg5704 @va-vfs-bot @va-vsp-bot