Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Melissa Staging email address for testing #12430

Merged
merged 0 commits into from
Apr 18, 2023

Conversation

holytoastr
Copy link
Contributor

@holytoastr holytoastr commented Apr 18, 2023

Summary

  • Need an email address that can be used to log into Flipper staging sandbox for testing. This is to get around an issue with a broken idme account that won't allow me to log in.
  • Have confirmed I can log in with this idme account
  • Login Adoption Team

Related issue(s)

N/A

Testing done

N/A

Screenshots

N/A

What areas of the site does it impact?

  • Adds access to Flipper admin panel on staging

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently working on a way for us manage Flipper Authorization through Github Teams instead of this file. Stay Tuned 😃

@holytoastr holytoastr merged commit 12d3741 into master Apr 18, 2023
@holytoastr holytoastr deleted the add-name-to-flipper-admin branch April 18, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants