Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include deduction code and resolution comment in FSR params #12434

Merged
merged 0 commits into from
Apr 19, 2023

Conversation

ScottyRJames
Copy link
Contributor

Summary

Individual compromise amounts were not being included in FSR due to parameters not being white listed

Related issue(s)

  • department-of-veterans-affairs/va.gov-team#0000

Testing done

  • Local

Screenshots

n/a

What areas of the site does it impact?

VHA FSR

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@ScottyRJames ScottyRJames merged commit 90e711a into master Apr 19, 2023
@ScottyRJames ScottyRJames deleted the 56748-update-compromise-fsr-params branch April 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants