Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

57042 Include code in TravelClaim Response when successful #12436

Merged
merged 0 commits into from
Apr 18, 2023

Conversation

randomsync
Copy link
Member

@randomsync randomsync commented Apr 18, 2023

Summary

Updated the Response object for TravelClaim to include code in the body when it is a successful response. This will help us determine which template to use when sending the notifications.

Related issue(s)

Testing done

  • rspecs
  • local testing

What areas of the site does it impact?

check in experience

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@randomsync randomsync requested review from a team as code owners April 18, 2023 19:14
@randomsync randomsync force-pushed the 57042_update_travelclaim_response branch from c8dbc7f to 63b5bd8 Compare April 18, 2023 20:09
@va-vsp-bot va-vsp-bot requested a deployment to 57042_update_travelclaim_response/main/main April 18, 2023 20:10 In progress
@randomsync randomsync force-pushed the 57042_update_travelclaim_response branch from 63b5bd8 to df96f3e Compare April 18, 2023 22:21
@va-vsp-bot va-vsp-bot requested a deployment to 57042_update_travelclaim_response/main/main April 18, 2023 22:22 In progress
Copy link
Contributor

@kanchanasuriya kanchanasuriya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randomsync randomsync merged commit bf56803 into master Apr 18, 2023
@randomsync randomsync deleted the 57042_update_travelclaim_response branch April 18, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants