Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds back 526 docs #12437

Merged
merged 0 commits into from
Apr 18, 2023
Merged

Adds back 526 docs #12437

merged 0 commits into from
Apr 18, 2023

Conversation

stiehlrod
Copy link
Contributor

Summary

adds docs for 526 schema

Related issue(s)

Testing done

Screenshots

Screenshot 2023-04-18 at 1 21 04 PM

What areas of the site does it impact?

modules/claims_api/spec/requests/v2/veterans/rswag_disability_compensation_request_spec.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels Apr 18, 2023
@stiehlrod stiehlrod self-assigned this Apr 18, 2023
@stiehlrod stiehlrod requested review from a team as code owners April 18, 2023 19:22
@va-vsp-bot va-vsp-bot requested a deployment to API-24681-526-schema-draft-2/main/main April 18, 2023 19:26 In progress
FonzMP
FonzMP approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stiehlrod stiehlrod merged commit c422cbc into master Apr 18, 2023
@stiehlrod stiehlrod deleted the API-24681-526-schema-draft-2 branch April 18, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FonzMP FonzMP FonzMP approved these changes

Assignees

@stiehlrod stiehlrod

Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stiehlrod @FonzMP @va-vsp-bot