Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 1010ez disability rating code to BGS #12442

Merged
merged 0 commits into from
Apr 24, 2023
Merged

Conversation

lihanli
Copy link
Contributor

@lihanli lihanli commented Apr 19, 2023

Summary

migrate from EVSS disability rating api to BGS disability rating api because the EVSS api is being deprecated. remove prefill_compensation_type code because the frontend is always sending the compensation type now and it doesn't need to be filled by the backend.

  • (Which team do you work for, does your team own the maintainence of this component?)
    i work for the 1010 team, we own this code

Related issue(s)

department-of-veterans-affairs/va.gov-team#56673

Testing done

tested with unit tests

What areas of the site does it impact?

1010ez form

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-vsp-bot va-vsp-bot requested a deployment to dis-rating-migration/main/main April 19, 2023 07:59 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to dis-rating-migration/main/main April 19, 2023 08:00 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to dis-rating-migration/main/main April 20, 2023 08:55 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to dis-rating-migration/main/main April 20, 2023 08:55 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to dis-rating-migration/main/main April 20, 2023 08:59 In progress
@lihanli lihanli changed the title Dis rating migration Migrate 1010 team disability rating code to BGS Apr 20, 2023
@lihanli lihanli changed the title Migrate 1010 team disability rating code to BGS Migrate 1010ez disability rating code to BGS Apr 20, 2023
@lihanli lihanli marked this pull request as ready for review April 20, 2023 09:11
@lihanli lihanli requested review from a team as code owners April 20, 2023 09:11
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lihanli lihanli merged commit a40b2ac into master Apr 24, 2023
@lihanli lihanli deleted the dis-rating-migration branch April 24, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants