-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mocked auth views #12444
Mocked auth views #12444
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Tested locally and was able to sign in. Just one comment but take it or leave it 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments from the spec fairy, lemme know if you need help with them. Otherwise looks good
modules/mocked_authentication/app/controllers/mocked_authentication/credential_controller.rb
Show resolved
Hide resolved
One other thing, is there any way to not show the 'encoded credential' part in the credential attribute view? Not a problem at all just unnecessary for the user |
modules/mocked_authentication/app/controllers/mocked_authentication/credential_controller.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@ryan-mcneil Can I get a re-approval now that specs are working and Rubocop isn't yelling at me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay!
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Summary
(Summarize the changes that have been made to the platform)
This PR creates a view for the mocked_authentication module to allow users to use the new Mocked Authentication flow and select mock profiles. (Only available in local and development environments)
(What is the solution, why is this the solution)
The solution was to create a template view for the
credential_controller
and add a new route/profiles
that exists on the/mocked_authentication
base. Some other components and tweaks in the mocked_authentication module were required to pass local variables to the template view.(Which team do you work for, does your team own the maintainence of this component?)
Identity. Yes.
Related issue(s)
Link to ticket created in va.gov-team repo
[FE] (Mock Authentication) - Work with BE Identity to generate proper URL for mocked CSP va.gov-team#53352
Link to epic if not included in ticket
[Mocked Auth] Mocked Authentication for Localhost and Development stacks va.gov-team#53015
Testing done
No frontend views were available for mocked authentication
Requirements: vets-website (
fe-integrate-mock-auth
), vets-api (this branch), vets-api-mockdata (mocked_auth
)localhost:3001/sign-in/mocked-auth
> Select ID.me from the Credential Service Provider dropdownlocalhost:3001
in an authenticated stateManual. Success.
What areas of the site does it impact?
This only impacts localhost & development environments on the
/mocked_authentication/profiles
route(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?