-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 25622 tracked item status #12451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with {{uri}}/services/claims/v2/veterans/1012826664V603033/claims/285456
, and am getting this stack trace:
"exception": "no implicit conversion of Symbol into Integer",
"backtrace": [ "/claims_controller.rb:495:in `block in find_tracked_item'",
@FonzMP @stiehlrod Please let me know once you've tested again and are happy with it, and I'll approve! |
modules/claims_api/app/controllers/claims_api/v2/veterans/claims_controller.rb
Outdated
Show resolved
Hide resolved
modules/claims_api/app/controllers/claims_api/v2/veterans/claims_controller.rb
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger |
@stiehlrod Returning a hash for tracked_items. I did not test on differing claims before pushing this so nice catch! I'll do a few more locally here, but these should handle the lone tracked item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested: {{uri}}/services/claims/v2/veterans/1012666073V986297/claims/600320269
, {{uri}}/services/claims/v2/veterans/1012666073V986297/claims/600334308
, and {{uri}}/services/claims/v2/veterans/1012666073V986297/claims/600336398
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria