Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 25622 tracked item status #12451

Merged
merged 0 commits into from
Apr 25, 2023
Merged

Api 25622 tracked item status #12451

merged 0 commits into from
Apr 25, 2023

Conversation

FonzMP
Copy link
Contributor

@FonzMP FonzMP commented Apr 19, 2023

Summary

  • Reworks tracked_items in v2 claims show

Related issue(s)

Testing done

  • RSpec and updated cassette

What areas of the site does it impact?

  • Claims V2

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@FonzMP FonzMP added the claimsApi modules/claims_api label Apr 19, 2023
@FonzMP FonzMP requested review from a team as code owners April 19, 2023 23:06
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 19, 2023 23:07 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 19, 2023 23:07 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 19, 2023 23:12 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 20, 2023 22:35 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 20, 2023 22:35 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 20, 2023 22:40 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 20, 2023 22:41 Inactive
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with {{uri}}/services/claims/v2/veterans/1012826664V603033/claims/285456, and am getting this stack trace:
"exception": "no implicit conversion of Symbol into Integer",
"backtrace": [ "/claims_controller.rb:495:in `block in find_tracked_item'",

@ryan-mcneil
Copy link
Contributor

@FonzMP @stiehlrod Please let me know once you've tested again and are happy with it, and I'll approve!

@ryan-mcneil ryan-mcneil self-assigned this Apr 21, 2023
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 15:27 In progress
@github-actions
Copy link

github-actions bot commented Apr 24, 2023

1 Warning
⚠️ This PR changes 207 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/controllers/claims_api/v2/veterans/claims_controller.rb (+100/-76)

  • modules/claims_api/spec/requests/v2/veterans/claims_request_spec.rb (+9/-20)

  • modules/claims_api/spec/requests/v2/veterans/rswag_claims_request_spec.rb (+1/-1)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@FonzMP
Copy link
Contributor Author

FonzMP commented Apr 24, 2023

Tested with {{uri}}/services/claims/v2/veterans/1012826664V603033/claims/285456, and am getting this stack trace: "exception": "no implicit conversion of Symbol into Integer", "backtrace": [ "/claims_controller.rb:495:in `block in find_tracked_item'",

@stiehlrod Returning a hash for tracked_items. I did not test on differing claims before pushing this so nice catch! I'll do a few more locally here, but these should handle the lone tracked item.

@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 15:30 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 24, 2023 15:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 24, 2023 15:35 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 15:38 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 24, 2023 15:40 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 15:44 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 24, 2023 15:50 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 15:59 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 24, 2023 16:18 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 19:07 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-25622_tracked_item_status/main/main April 24, 2023 19:08 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-25622_tracked_item_status/main/main April 24, 2023 19:31 In progress
Copy link
Contributor

@stiehlrod stiehlrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: {{uri}}/services/claims/v2/veterans/1012666073V986297/claims/600320269, {{uri}}/services/claims/v2/veterans/1012666073V986297/claims/600334308, and {{uri}}/services/claims/v2/veterans/1012666073V986297/claims/600336398

@FonzMP FonzMP merged commit feaf6b9 into master Apr 25, 2023
@FonzMP FonzMP deleted the API-25622_tracked_item_status branch April 25, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants