Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaNotify - Add job class to allow for one time in progress reminders #12459

Merged
merged 0 commits into from
Apr 24, 2023

Conversation

nathanbwright
Copy link
Contributor

Summary

  • Adds job to allow for sending one time in progress notifications.

Related issue(s)

Testing done

  • Rspec specs

Screenshots

Note: Optional

What areas of the site does it impact?

Does not impact any existing functionality - only adds for future functionality.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Solid testing 👌

@nathanbwright nathanbwright merged commit e0792eb into master Apr 24, 2023
@nathanbwright nathanbwright deleted the vanotify-909/one-time-in-progress branch April 24, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants