Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require so PdfFill module is found #12479

Merged
merged 0 commits into from
Apr 26, 2023
Merged

Add require so PdfFill module is found #12479

merged 0 commits into from
Apr 26, 2023

Conversation

michelpmcdonald
Copy link
Contributor

@michelpmcdonald michelpmcdonald commented Apr 26, 2023

Summary

We noticed that one of our teams unit test, modules/appeals_api/spec/workers/pdf_submit_job_spec.rb, was causing an uninitialized constant error for the PdfFill module.

Not exactly sure what changed, but adding a require fixes it.

Similar to this PR:
#12478

Testing done

Ran unit test in question, failed, added require, unit test passed

What areas of the site does it impact?

Unit test

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).

@michelpmcdonald michelpmcdonald added Lighthouse lighthouse appeals Lighthouse API appeals banana-peels Lighthouse Banana Peels Team and removed console-services-review labels Apr 26, 2023
@michelpmcdonald michelpmcdonald marked this pull request as ready for review April 26, 2023 14:59
@michelpmcdonald michelpmcdonald requested review from a team as code owners April 26, 2023 14:59
@kristen-brown kristen-brown merged commit 353c867 into master Apr 26, 2023
@kristen-brown kristen-brown deleted the pdf-fill-fix branch April 26, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appeals Lighthouse API appeals banana-peels Lighthouse Banana Peels Team Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants