Bump rack-test from 1.1.0 to 2.1.0 #12715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vfs-bot
temporarily deployed
to
dependabot/bundler/rack-test-2.1.0/main/main
ryan-mcneil
previously approved these changes
May 25, 2023
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
va-vsp-bot
requested a deployment
to
dependabot/bundler/rack-test-2.1.0/main/main
ryan-mcneil
reviewed
May 31, 2023
| @@ -52,7 +52,7 @@ def documents | |||
| @documents ||= params.slice(*document_keys).values.map do |document| | |||
| case document | |||
| when String | |||
| decode_document(document) | |||
| document.blank? ? nil : decode_document(document) | |||
There was a problem hiding this comment.
rack-test was converting a nil attachment to a blank string, which was causing a failure down the road here
ryan-mcneil
reviewed
May 31, 2023
| @@ -101,7 +101,7 @@ def self.get_partname(headers) | |||
| def self.get_content_type(headers) | |||
| headers.each do |header| | |||
| name, _, value = header.partition(':') | |||
| return value.split(';')[0].strip if name == 'Content-Type' | |||
| return value.split(';')[0].strip if name.downcase == 'content-type' | |||
There was a problem hiding this comment.
rack-test start sending headers downcased, so I just made these comparisons agnostic of the case of the header
There was a problem hiding this comment.
related: rack/rack#1592
rmtolmach
approved these changes
May 31, 2023
ryan-mcneil
added a commit
that referenced
this pull request
Dec 11, 2023
* Bump rack-test from 1.1.0 to 2.1.0 Bumps [rack-test](https://github.com/rack/rack-test) from 1.1.0 to 2.1.0. - [Release notes](https://github.com/rack/rack-test/releases) - [Changelog](https://github.com/rack/rack-test/blob/main/History.md) - [Commits](rack/rack-test@v1.1.0...v2.1.0) --- updated-dependencies: - dependency-name: rack-test dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * fix capitalization issue with rack-test * add case for empty string (rack-test) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan McNeil <ryan.mcneil@oddball.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rack-test from 1.1.0 to 2.1.0.
Changelog
Sourced from rack-test's changelog.
... (truncated)
Commits
867a6f1Release 2.1.044e8be4Update History.md5a2a3bfDon't raise error with empty params and multipart headerfebbea4Update CHANGELOG79c5077Fix tests when rack master branch is used70f4db2Ignore leading dot when merging cookies73c7174Bump cgi version in Ruby 3.1 CI test8fb4fb2Add CI for Ruby 3.210e7040Test JRuby 9.4 in CI2036831change order of arguments forassert_equalexample in READMEDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)