Bdex/57064 migrate post intent to file to lighthouse #12753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navaeddie
reviewed
May 22, 2023
| @@ -5,21 +5,30 @@ | |||
| module V0 | |||
| class BenefitsClaimsController < ApplicationController | |||
| def index | |||
| claims = service.get_claims | |||
| claims = service.get_claims(settings.access_token.client_id, settings.access_token.rsa_key) | |||
There was a problem hiding this comment.
We removed these arguments on get_claims and get_claim on Friday - so we can avoid changes to Claim Status Tool Team's code.
There was a problem hiding this comment.
Ah thanks for noting. I think some of the diffs here are because this branch is downstream from yours; if we removed it, I'll either update with yours, or master after yours merges in
There was a problem hiding this comment.
hey mark, i think what eddie was trying to say here is that we don't need to change this file at all. we can remove the arguments that pertain to the lighthouse credentials in this file.
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
aurora-a-k-a-lightning
requested changes
May 23, 2023
spec/lib/disability_compensation/providers/intent_to_file/evss_intent_to_file_provider_spec.rb
Outdated
Show resolved
Hide resolved
lib/disability_compensation/providers/intent_to_file/lighthouse_intent_to_file_provider.rb
Show resolved
Hide resolved
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
aurora-a-k-a-lightning
requested changes
May 26, 2023
| @@ -5,21 +5,30 @@ | |||
| module V0 | |||
| class BenefitsClaimsController < ApplicationController | |||
| def index | |||
| claims = service.get_claims | |||
| claims = service.get_claims(settings.access_token.client_id, settings.access_token.rsa_key) | |||
There was a problem hiding this comment.
hey mark, i think what eddie was trying to say here is that we don't need to change this file at all. we can remove the arguments that pertain to the lighthouse credentials in this file.
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
va-vsp-bot
requested a deployment
to
bdex/57064-migrate-post-intent_to_file-to_lighthouse/main/main
aurora-a-k-a-lightning
approved these changes
May 26, 2023
mchae-nava
changed the title
mchae-nava
deleted the
bdex/57064-migrate-post-intent_to_file-to_lighthouse
branch
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
* implement GET request for Lighthouse intent-to-file * modify BenefitsClaims::Service to request intent to file data * extend BenefitsService::Configuration to handle different consumer/client needs * modify existing BenefitsClaims index and show operations to handle new configuration * implement GET request for Lighthouse intent-to-file * modify BenefitsClaims::Service to request intent to file data * extend BenefitsService::Configuration to handle different consumer/client needs * modify existing BenefitsClaims index and show operations to handle new configuration * add parameters to fix evss method, move transform to private method, rm unneeded comment * add error handling and request specs * fix a few request specs * fix some tests to accommodate provider pattern * fix rubocop errors, add tests to lighthouse itf provider * Merge branch 'bdex/57063/migrate-get-intent_to_file-to-lighthouse' of https://github.com/department-of-veterans-affairs/vets-api into bdex/57063/migrate-get-intent_to_file-to-lighthouse * Implement service ITF post * Add TODO for swagger spec * implement GET request for Lighthouse intent-to-file * modify BenefitsClaims::Service to request intent to file data * extend BenefitsService::Configuration to handle different consumer/client needs * modify existing BenefitsClaims index and show operations to handle new configuration * add parameters to fix evss method, move transform to private method, rm unneeded comment * add error handling and request specs * fix a few request specs * fix some tests to accommodate provider pattern * fix rubocop errors, add tests to lighthouse itf provider * a little cleanup, fixing errors in lighthouse service, config, and spec * Revert "Add TODO for swagger spec" This reverts commit e92bd8b7e2e92dd29820722568ace32109ce5436. * minor tweak for Rubocop and require needed files * Correct stomped swagger_spec * Remove committed debug statements; Update TODOs to be more indexable * Update parameters of evss provider * Add template automated tests * Correct improper identifier in EVSS ITF provider * Correct LH provider parameters and tests * Update evss itf spec * Update LH ITF specs; Attempt VCR continuous integration; Add mock responses * Remove some TODOs * Add missing param to service spec * Some cleanup and missed comments * Change create to supply ssn on function call instead of initialize; Simpliy current_user interface * Regenerate VCR cassettes * Add some future TODO considerations; Fix expects to match data structure * Fix missed parameter update * Linting auto-fixes * Revert changes to benefits_claims_controller * Commit removing credentials from intent_to_files_controller * Remove missed comments and unused var assignment --------- Co-authored-by: Eddie Glenn <eddieglenn@navapbc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
57064
Testing done
What areas of the site does it impact?
526 Backend; Ideally impact is not noticeable
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?