API-26966-526-v2-req-body-updates & API-27054

[stiehlrod]

Summary

• Updates 526 Request body's 'Example Value' to align with validation
• Updates enum for /homeless/riskOfBecomingHomeless/livingSituationOptions
• Fixes validation errors (caused by example.json not matching form_526_json_api.json)
• Adds verify access for ticket 27054

Related issue(s)

• API-26966
• API-27054

Testing done

• rspec
• Postman

What areas of the site does it impact?

modified:   modules/claims_api/config/schemas/v2/526.json
modified:   modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified:   modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified:   modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified:   modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
modified:   modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[FonzMP]

dev/swagger needs updated with this.

[github-actions]

1 Warning

⚠️

This PR changes 410 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb (+2/-0) modules/claims_api/lib/claims_api/v2/disability_compensation_pdf_mapper.rb (+2/-1) modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb (+9/-9) modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+209/-178) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[rockwellwindsor-va]

Looks good to us!