Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move mobile cassettes to root spec folder #12847

Merged
merged 0 commits into from
Jun 1, 2023
Merged

move mobile cassettes to root spec folder #12847

merged 0 commits into from
Jun 1, 2023

Conversation

aherzberg
Copy link
Contributor

@aherzberg aherzberg commented May 31, 2023 •
edited
Loading

Summary

We currently have our vcr cassettes in the mobile module of vets api. We are the only team that does this, and it requires boilerplate setting/unsetting of the cassette directory any time we have a test that uses cassettes. We already have permission to skip needing other team approval for writing to vets-api/spec/support/vcr_cassettes/mobile so this ticket is to move all of our cassettes to that directly and remove the boilerplate code

Related issue(s)

department-of-veterans-affairs/va-mobile-app#5713

Testing done

specs

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@github-actions
Copy link

github-actions bot commented May 31, 2023 •
edited
Loading

1 Error
🚫 This PR changes 1064 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • modules/mobile/spec/controllers/application_controller_spec.rb (+1/-1)

  • modules/mobile/spec/controllers/profile_base_controller_spec.rb (+2/-2)

  • modules/mobile/spec/request/addresses_request_spec.rb (+22/-29)

  • modules/mobile/spec/request/appointments_cancel_request_spec.rb (+4/-11)

  • modules/mobile/spec/request/appointments_create_request_spec.rb (+8/-13)

  • modules/mobile/spec/request/appointments_preferences_request_spec.rb (+4/-11)

  • modules/mobile/spec/request/appointments_vaos_v2_list_request_spec.rb (+26/-28)

  • modules/mobile/spec/request/attachments_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/claims_and_appeals_overview_request_spec.rb (+12/-19)

  • modules/mobile/spec/request/claims_decision_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/claims_document_upload_spec.rb (+1/-1)

  • modules/mobile/spec/request/clinics_request_spec.rb (+7/-14)

  • modules/mobile/spec/request/community_care_eligibility_request_spec.rb (+4/-11)

  • modules/mobile/spec/request/community_care_providers_request_spec.rb (+14/-19)

  • modules/mobile/spec/request/decision_letters_request_spec.rb (+5/-5)

  • modules/mobile/spec/request/disability_rating_request_spec.rb (+23/-30)

  • modules/mobile/spec/request/discovery_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/emails_request_spec.rb (+10/-17)

  • modules/mobile/spec/request/facilities_info_request_spec.rb (+10/-17)

  • modules/mobile/spec/request/facility_eligibility_request_spec.rb (+7/-14)

  • modules/mobile/spec/request/folders_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/gender_identity_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/immunizations_request_spec.rb (+14/-17)

  • modules/mobile/spec/request/individual_appeal_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/individual_claim_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/individual_lighthouse_claim_request_spec.rb (+3/-10)

  • modules/mobile/spec/request/legacy_letters_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/letters_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/locations_request_spec.rb (+7/-14)

  • modules/mobile/spec/request/maintenance_windows_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/message_drafts_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/messages_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/military_information_request_spec.rb (+5/-12)

  • modules/mobile/spec/request/payment_history_request_spec.rb (+15/-16)

  • modules/mobile/spec/request/payment_information_request_spec.rb (+2/-9)

  • modules/mobile/spec/request/phones_request_spec.rb (+10/-17)

  • modules/mobile/spec/request/preferred_name_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/prescriptions_request_spec.rb (+23/-30)

  • modules/mobile/spec/request/push_get_prefs_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/push_register_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/push_send_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/push_set_pref_request_spec.rb (+1/-1)

  • modules/mobile/spec/request/triage_teams_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/user_request_spec.rb (+54/-58)

  • modules/mobile/spec/request/v1/immunizations_request_spec.rb (+21/-27)

  • modules/mobile/spec/request/v1/messages_request_spec.rb (+2/-2)

  • modules/mobile/spec/request/v1/user_request_spec.rb (+50/-57)

  • modules/mobile/spec/request/veterans_affairs_eligibility_request_spec.rb (+7/-12)

  • modules/mobile/spec/services/lighthouse_health_service_spec.rb (+4/-10)

  • modules/mobile/spec/services/sync_update_service_spec.rb (+14/-21)

  • modules/mobile/spec/support/{ => helpers}/iam_session_helper.rb (+4/-2)

  • modules/mobile/spec/support/{ => helpers}/mobile_sm_client_helper.rb (+1/-1)

  • modules/mobile/spec/workers/pre_cache_appointments_job_spec.rb (+10/-16)

  • modules/mobile/spec/workers/pre_cache_claims_and_appeals_job_spec.rb (+7/-11)

  • modules/mobile/spec/workers/vet360_linking_spec.rb (+6/-13)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

@va-vsp-bot va-vsp-bot requested a deployment to 5713-move-mobile-vcrs/main/main May 31, 2023 17:45 In progress
aherzberg
aherzberg commented May 31, 2023
View reviewed changes
modules/mobile/spec/support/helpers/iam_session_helper.rb Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint fix demanded by rubocop

aherzberg
aherzberg commented May 31, 2023
View reviewed changes
modules/mobile/spec/support/helpers/mobile_sm_client_helper.rb
@@ -8,7 +8,7 @@ module MessagingClientHelper

def authenticated_client
Mobile::V0::Messaging::Client.new(session: { user_id: 123,
expires_at: Time.current + 60 * 60,
expires_at: Time.current + (60 * 60),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint fix demanded by rubocop

@aherzberg
Copy link
Contributor Author

I'm going to request another exception to the LOC limit as all changes are identical.

@va-vfs-bot va-vfs-bot temporarily deployed to 5713-move-mobile-vcrs/main/main May 31, 2023 17:51 Inactive
@aherzberg aherzberg marked this pull request as ready for review May 31, 2023 18:12
@aherzberg aherzberg requested review from a team as code owners May 31, 2023 18:12
@va-vsp-bot va-vsp-bot requested a deployment to 5713-move-mobile-vcrs/main/main May 31, 2023 18:13 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 5713-move-mobile-vcrs/main/main May 31, 2023 18:14 Inactive
Tonksthebear
Tonksthebear approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@Tonksthebear Tonksthebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. LGTM. Makes sense to have helpers in a helpers folder

kpethtel
kpethtel approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like you won the lines of code changed award this year. Obviously this will create some merge conflicts with open PRs but we've gotta pull off the bandaid eventually.

@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Jun 1, 2023
Closed
@va-vsp-bot va-vsp-bot requested a deployment to 5713-move-mobile-vcrs/main/main June 1, 2023 16:32 In progress
@jeremy6d jeremy6d merged commit e8564ad into master Jun 1, 2023
@jeremy6d jeremy6d deleted the 5713-move-mobile-vcrs branch June 1, 2023 16:58
@jeremy6d
Copy link
Contributor

jeremy6d commented Jun 1, 2023

Bypassed the LOC check because of the nature of the changes -- all just moving cassettes and removing unneeded setup

ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@aherzberg
move mobile cassettes to root spec folder (#12847)
99887ed 
* move mobile cassettes to root

* lint fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpethtel kpethtel kpethtel approved these changes

@Tonksthebear Tonksthebear Tonksthebear approved these changes

@jeremy6d jeremy6d jeremy6d approved these changes

Assignees
No one assigned
Labels
console-services-review mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aherzberg @jeremy6d @Tonksthebear @kpethtel @va-vfs-bot @va-vsp-bot