Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile - for lighthouse claims, remove concurrent processes on claims and appeals #12849

Merged
merged 0 commits into from
May 31, 2023

Conversation

aherzberg
Copy link
Contributor

Summary

when a staging user is using Lighthouse for claims, we're finding a high rate of errors. see: http://sentry.vfs.va.gov/organizations/vsp/issues/115127/events/978a9714706b400abdb29528f8c71533/?environment=staging&project=3&query=is%3Aunresolved+Access+token+JWT+is+malformed&statsPeriod=24h

one thing that we do that the benefits team does not is create concurrent async processes to get index claims data and appeals data. I think there is a race condition happening when reading the necessary LH key files that is causing this error. This PR tests that theory.

Related issue(s)

department-of-veterans-affairs/va-mobile-app#5794

Testing done

specs

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@kpethtel kpethtel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rachal and I talked about this recently but it didn't occur to me that it could be from the trying to access the tokens in parallel. I suppose we should keep an eye on the DD metrics to see how much of a performance impact this has on the endpoint latency.

@aherzberg aherzberg merged commit eb4eada into master May 31, 2023
@aherzberg aherzberg deleted the 5794-timeout-issue branch May 31, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants