Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes user.fingerprint to request.remote_ip for better accuracy #12878

Merged
merged 0 commits into from
Jun 5, 2023
Merged

changes user.fingerprint to request.remote_ip for better accuracy #12878

merged 0 commits into from
Jun 5, 2023

Conversation

bramleyjl
Copy link
Contributor

Summary

Small improvements to user.fingerprint, using request.remote_ip to account for being behind load balancers & proxies. We wish to improve accuracy of our fingerprint mismatching detection and reduce false positives to give the metric more use.

Related issue(s)

  • department-of-veterans-affairs/va.gov-team-sensitive/922

Testing done

  • affected unit specs updated

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution

@bramleyjl bramleyjl added identity identity-backend Identity team backend label labels Jun 2, 2023
@bramleyjl bramleyjl self-assigned this Jun 2, 2023
@bramleyjl bramleyjl requested review from a team as code owners June 2, 2023 18:52
@va-vsp-bot va-vsp-bot requested a deployment to request-remote-ip/main/main June 2, 2023 18:53 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to request-remote-ip/main/main June 2, 2023 18:59 Inactive
rileyanderson
rileyanderson approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@rileyanderson rileyanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@va-vsp-bot va-vsp-bot requested a deployment to request-remote-ip/main/main June 5, 2023 15:39 In progress
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Jun 5, 2023
Closed
ryan-mcneil
ryan-mcneil approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bramleyjl bramleyjl merged commit 94ae98a into master Jun 5, 2023
@bramleyjl bramleyjl deleted the request-remote-ip branch June 5, 2023 20:51
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@bramleyjl
changes user.fingerprint to request.remote_ip for better accuracy (#1…
343ade3 
…2878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-mcneil ryan-mcneil ryan-mcneil approved these changes

@rileyanderson rileyanderson rileyanderson approved these changes

Assignees

@bramleyjl bramleyjl

Labels
console-services-review identity identity-backend Identity team backend label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bramleyjl @rileyanderson @ryan-mcneil @va-vfs-bot @va-vsp-bot