Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-27180-add-526-v2-getpdf-endpoint #12913

Merged
merged 0 commits into from
Jun 12, 2023

Conversation

rockwellwindsor-va
Copy link
Contributor

Adds a new endpoint to our v2 526 services for /getPDF.

Summary

  • Adds /526/getPDF endpoint (GET)
  • Adds Route in routes file for the endpoint

Related issue(s)

API-27180

Testing done

  • Ran RSpec to make sure everything is still green, but the method is empty so nothing to test on it yet.

What areas of the site does it impact?

modified: modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
modified: modules/claims_api/config/routes.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to API-27180-add-526-v2-getpdf-endpoint/main/main June 6, 2023 20:41 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 13:21 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 13:22 Inactive
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review June 7, 2023 13:46
@rockwellwindsor-va rockwellwindsor-va requested review from a team as code owners June 7, 2023 13:46
@va-vsp-bot va-vsp-bot requested a deployment to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 14:34 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 14:39 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 16:06 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 16:15 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 18:52 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27180-add-526-v2-getpdf-endpoint/main/main June 7, 2023 19:16 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27180-add-526-v2-getpdf-endpoint/main/main June 8, 2023 13:27 In progress
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rockwellwindsor-va rockwellwindsor-va merged commit bc4edad into master Jun 12, 2023
@rockwellwindsor-va rockwellwindsor-va deleted the API-27180-add-526-v2-getpdf-endpoint branch June 12, 2023 13:13
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
* Adds /526/getPDF endpoint (GET)
* Adds Route in routes file for the endpoint

Changes to be committed:
	modified:   modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
	modified:   modules/claims_api/config/routes.rb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants