Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12929] Properly adding idme_uuid as a field when user model is reloaded #12930

Merged
merged 0 commits into from
Jun 8, 2023

Conversation

bosawt
Copy link
Contributor

@bosawt bosawt commented Jun 7, 2023

Summary

  • This PR makes it so that user.idme_uuid properly persists after the User model is reloaded (when the User redis expires and is recreated), specifically for users authenticating with DSLogon and MyHealtheVet.

Related issue(s)

Testing done

  • Authenticated with DSLogon on Sign in Service
  • On Rails console, deleted the User model associated with the redis that was created for the authenticated user
  • Called an authenticated route, and confirm that the User model was recreated, and that user.idme_uuid is not nil

What areas of the site does it impact?

General Application usage for DSLogon and MHV clients (who are authenticated with Sign in Service

Acceptance criteria

  • Authenticate with DSLogon or MHV with Sign in Service
  • On Rails console, find the user redis model User.find(<idme_uuid>) where idme_uuid is the backing idme_uuid for the account
  • Delete the redis model
  • Call any authenticated route, and confirm the redis model was recreated (User.find(<idme_uuid>) does not return nil)
  • Confirm that user.idme_uuid is not nil

Copy link
Contributor

@rileyanderson rileyanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. My User was recreated after destroying it 🚀

@bosawt bosawt merged commit e827b1e into master Jun 8, 2023
@bosawt bosawt deleted the 12929_fix_bug_missing_idme_uuid branch June 8, 2023 20:19
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
…ded (#12930)

Co-authored-by: Trevor Bosaw <trevor.bosaw@oddball.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants